Fixes serialization of two Adviser fields in Investment search. #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canni
reviewed
Jul 11, 2017
datahub/search/models.py
Outdated
| 'id': String(index='not_analyzed'), | ||
| 'name': String()} | ||
| ) # Adviser | ||
| project_manager = Nested(properties={'id': String(index='not_analyzed'), |
There was a problem hiding this comment.
Can we re-use properties dict here?
There was a problem hiding this comment.
Perhaps it could be generalised - there would be some fun with copy_to parameters.
reupen
approved these changes
Jul 11, 2017
Codecov Report
@@ Coverage Diff @@
## develop #294 +/- ##
========================================
Coverage 92.87% 92.87%
========================================
Files 63 63
Lines 2427 2427
Branches 215 215
========================================
Hits 2254 2254
Misses 145 145
Partials 28 28Continue to review full report at Codecov.
|
reupen
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.