Output financial year for Win breakdown dataset. #5301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This replaces relative year in Breakdowns with actual financial year based on related Win created date.
Pseudo code:
Financial Year = get_financial_year(win.created_on) + (breakdown.year - 1)
Financial year is assumed from 1 April to 31 March.
Example:
If Win was created on 02/2024 and breakdown year is 1, then financial year is 2023
If Win was created on 04/2024 and breakdown year is 1, then financial year is 2024
If Win was created on 02/2024 and breakdown year is 2, then financial year is 2024
Checklist
Has this branch been rebased on top of the current
main
branch?Explanation
The branch should not be stale or have conflicts at the time reviews are requested.
Is the CircleCI build passing?
General points
Other things to check
fixtures/test_data.yaml
is maintained when updating modelsSee docs/CONTRIBUTING.md for more guidelines.