Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output financial year for Win breakdown dataset. #5301

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Mar 28, 2024

Description of change

This replaces relative year in Breakdowns with actual financial year based on related Win created date.

Pseudo code:
Financial Year = get_financial_year(win.created_on) + (breakdown.year - 1)

Financial year is assumed from 1 April to 31 March.

Example:
If Win was created on 02/2024 and breakdown year is 1, then financial year is 2023
If Win was created on 04/2024 and breakdown year is 1, then financial year is 2024
If Win was created on 02/2024 and breakdown year is 2, then financial year is 2024

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner March 28, 2024 11:32
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (95ab095) to head (4caeb9e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5301      +/-   ##
==========================================
- Coverage   96.46%   96.45%   -0.01%     
==========================================
  Files         923      923              
  Lines       21873    21873              
  Branches     1959     1959              
==========================================
- Hits        21100    21098       -2     
- Misses        625      626       +1     
- Partials      148      149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct merged commit b990660 into main Mar 28, 2024
4 checks passed
@elcct elcct deleted the feature/ew-breakdowns-financial-year branch March 28, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants