DPM 199 Data Hub API logging #5304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## migration-deploy #5304 +/- ##
=================================================
Coverage 96.50% 96.50%
=================================================
Files 924 924
Lines 21900 21900
Branches 1962 1962
=================================================
Hits 21134 21134
Misses 619 619
Partials 147 147 ☔ View full report in Codecov by Sentry. |
cgsunkel
approved these changes
Mar 28, 2024
oliverjwroberts
approved these changes
Mar 28, 2024
| pandas==2.2.1 | ||
| # via -r requirements.in | ||
| platformdirs==4.2.0 | ||
| # via virtualenv | ||
| pre-commit==3.7.0 |
There was a problem hiding this comment.
Is pre-commit needed in the normal/non-dev requirements?
There was a problem hiding this comment.
If I interpret the structure of the requirements.txt correctly pre-commit is required by django-log-formatter-asim
marijnkampf
added a commit
that referenced
this pull request
Apr 2, 2024
* Change logging to ASIM formatter * Update common_logging.py
bau123
pushed a commit
that referenced
this pull request
Apr 9, 2024
* Change logging to ASIM formatter * Update common_logging.py
bau123
pushed a commit
that referenced
this pull request
Apr 9, 2024
* Change logging to ASIM formatter * Update common_logging.py
marijnkampf
added a commit
that referenced
this pull request
May 20, 2024
* Change logging to ASIM formatter * Update common_logging.py
marijnkampf
added a commit
that referenced
this pull request
Jul 1, 2024
* Change logging to ASIM formatter * Update common_logging.py
cgsunkel
pushed a commit
that referenced
this pull request
Jul 15, 2024
* Change logging to ASIM formatter * Update common_logging.py
cgsunkel
added a commit
that referenced
this pull request
Jul 15, 2024
* Update codeowners * Add sample rate to sentry (#5532) * Add sample rate to sentry * Add new action for govpaas branch * Bump django from 4.2.11 to 4.2.14 (#5536) Bumps [django](https://github.com/django/django) from 4.2.11 to 4.2.14. - [Commits](django/django@4.2.11...4.2.14) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add new fields to sentry config (#5537) * Remove migration actions (#5538) * Update redis * Update open search * Update pingdom end point url * Feature/dpm 174 data hub api investigate rq health check (#5266) * Create Command for rq health check and include in docker-compose.yml configuration. * DPM 199 Data Hub API logging (#5304) * Change logging to ASIM formatter * Update common_logging.py * do not run collectstatic at run time on DBT Platform * add build configuration for DBT Platform * remove debug setup * Migration/DPM 343 Data Hub API application settings (#5340) * Change DATABASE_URL connection string to DATABASE_CREDENTIALS containing JSON structure. * update database environment for build job * Rename reserved environment variables (#5345) * Debug: DBT Platform * Debug: metadata hawk authentication * Debug: DBT Patch * Debug: test on sector filter * Debug: Hawk * Undo debugging * Fix Flake8 Missing newline between import groups (#5457) * TET 801 Stop Opensearch addess showing credentials (#5519) * Stop showing open search credentials on connection error. * Allow for setting of pool maxsize on open search connection. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Christopher <christopher.sunkel@digital.trade.gov.uk> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lawrence Goldstien <lawrence.goldstein@digital.trade.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Change logging to ASIM format.
Checklist
Has this branch been rebased on top of the current
mainbranch?Explanation
The branch should not be stale or have conflicts at the time reviews are requested.
Is the CircleCI build passing?
General points
Other things to check
fixtures/test_data.yamlis maintained when updating modelsSee docs/CONTRIBUTING.md for more guidelines.