Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/RR-1343-allow-export-wins-access-to-autocomplete #5329

Merged

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Apr 4, 2024

Description of change

When an export wins admin user is using the django autocomplete field, instead of explicitly denying access to anything except the export_win app, forward the permission check to the standard django permission check function.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@chopkinsmade chopkinsmade marked this pull request as ready for review April 4, 2024 11:04
@chopkinsmade chopkinsmade requested a review from a team as a code owner April 4, 2024 11:04
@chopkinsmade chopkinsmade merged commit 57fa0bc into main Apr 4, 2024
2 checks passed
@chopkinsmade chopkinsmade deleted the bugfix/RR-1343-allow-export-wins-access-to-autocomplete branch April 4, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants