Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/RR-1355-wins-admin-screen #5332

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Apr 5, 2024

Description of change

  • Add a new admin page for the WinAdviser model
  • Update the display name of the Win model to match what is displayed in the export wins system (Export win <Win ID>: <adviser name> <adviser email> - <date stamp> <time stamp>)
  • Update the display name of the WinAdviser model to match what is displayed in the export wins system (Name <adviser name>, Team <team_type> - <hq_team>)

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@chopkinsmade chopkinsmade marked this pull request as ready for review April 5, 2024 11:08
@chopkinsmade chopkinsmade requested a review from a team as a code owner April 5, 2024 11:08
Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth considering. View full project report here.

datahub/export_win/models.py Outdated Show resolved Hide resolved
datahub/export_win/models.py Outdated Show resolved Hide resolved
@chopkinsmade chopkinsmade marked this pull request as draft April 5, 2024 11:09
@chopkinsmade chopkinsmade marked this pull request as ready for review April 5, 2024 12:22
@chopkinsmade chopkinsmade removed the wip label Apr 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (decf865) to head (8fecc2f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5332   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files         925      925           
  Lines       21956    21964    +8     
  Branches     1964     1965    +1     
=======================================
+ Hits        21196    21204    +8     
  Misses        616      616           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade merged commit b261ba9 into main Apr 8, 2024
2 checks passed
@chopkinsmade chopkinsmade deleted the feature/RR-1355-wins-admin-screen branch April 8, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants