Data Hub Test Data - Investment Project Generator #5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## firebreak/data-hub-test-data #5393 +/- ##
================================================================
- Coverage 96.40% 96.40% -0.01%
================================================================
Files 939 939
Lines 22334 22334
Branches 2003 2003
================================================================
- Hits 21532 21530 -2
- Misses 655 656 +1
- Partials 147 148 +1 ☔ View full report in Codecov by Sentry. |
marijnkampf
approved these changes
May 9, 2024
Comment on lines
+36
to
+44
| # Handle case when requested number is too small | ||
| if number_of_companies < 10: | ||
| for adviser in advisers[:number_of_companies]: | ||
| CompanyFactory( | ||
| created_by=adviser, | ||
| modified_by=adviser, | ||
| ) | ||
| print(f'Generated {number_of_companies} companies') # noqa | ||
| return |
There was a problem hiding this comment.
Should/could this be refactored into a function to bring down the size of the generate_companies one?
There was a problem hiding this comment.
I agree, there is some refactoring opportunity here. What I will do is merge in this PR and raise a subsequent one with a number of refactors, including this suggestion, to keep things clearer.
oliverjwroberts
force-pushed
the
firebreak/data-hub-test-data
branch
from
982805b to
9b50190
Compare
oliverjwroberts
force-pushed
the
firebreak/data-hub-test-data--investments
branch
from
da4994b to
601d541
Compare
oliverjwroberts
merged this pull request
into
firebreak/data-hub-test-data
2 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR ports over the existing adviser and company generators to a new
datagen.pyscript (with the intention to replace thedata_generator.pyscript in a subsequent PR.It also adds a generator for invesmtnent projects.
Checklist
Has this branch been rebased on top of the current
mainbranch?Explanation
The branch should not be stale or have conflicts at the time reviews are requested.
Is the CircleCI build passing?
General points
Other things to check
fixtures/test_data.yamlis maintained when updating modelsSee docs/CONTRIBUTING.md for more guidelines.