Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hvc codes in Export win dataset. #5404

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix hvc codes in Export win dataset. #5404

merged 1 commit into from
May 8, 2024

Conversation

elcct
Copy link
Contributor

@elcct elcct commented May 7, 2024

Description of change

The new HVC codes don't have legacy win id, so they were not showing up correctly in the Export win dataset.
This reconstructs the id from campaign_id and financial_year.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner May 7, 2024 16:40
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (027a996) to head (fbbf6e7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5404   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         938      938           
  Lines       22326    22326           
  Branches     2002     2002           
=======================================
  Hits        21522    21522           
  Misses        655      655           
  Partials      149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct merged commit e1580b1 into main May 8, 2024
2 checks passed
@elcct elcct deleted the fix/new-hvc-codes branch May 8, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants