Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop adding additional payments to an order #5405

Merged
merged 1 commit into from
May 10, 2024

Conversation

Richard-Pentecost
Copy link
Contributor

@Richard-Pentecost Richard-Pentecost commented May 8, 2024

Delete any payments that already belong to the order being seeded in the database. The e2e tests, test for there being 2 payments for an order that is put in the database and has been paid. Previously when running the api locally, if you stopped and then restarted without deleting the database, it would add another 2 payments for this order each time you restarted causing locally run e2e tests to fail. Fix put in to delete any payments from the database for this order when creating the order

Description of change

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@Richard-Pentecost Richard-Pentecost requested a review from a team as a code owner May 8, 2024 18:29
Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to consider. View full project report here.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@af3a13d). Click here to learn what that means.
Report is 5 commits behind head on main.

Files Patch % Lines
...mis/order/management/commands/set_order_as_paid.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5405   +/-   ##
=======================================
  Coverage        ?   96.39%           
=======================================
  Files           ?      938           
  Lines           ?    22328           
  Branches        ?     2002           
=======================================
  Hits            ?    21524           
  Misses          ?      656           
  Partials        ?      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Richard-Pentecost Richard-Pentecost force-pushed the fix/stop-adding-additional-payments branch from 96631bf to 02d8d73 Compare May 9, 2024 13:15
@Richard-Pentecost Richard-Pentecost merged commit b51f9c7 into main May 10, 2024
2 checks passed
@Richard-Pentecost Richard-Pentecost deleted the fix/stop-adding-additional-payments branch May 10, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants