Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of missing fields in Legacy export wins. #5415

Merged
merged 1 commit into from
May 15, 2024

Conversation

elcct
Copy link
Contributor

@elcct elcct commented May 14, 2024

Description of change

Some legacy export wins have fields missing or coming with null value which was not handled properly.
This fixes it.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner May 14, 2024 12:55
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (5a4df6a) to head (2462763).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5415      +/-   ##
==========================================
- Coverage   96.40%   96.40%   -0.01%     
==========================================
  Files         939      940       +1     
  Lines       22335    22341       +6     
  Branches     2003     2003              
==========================================
+ Hits        21533    21537       +4     
- Misses        655      656       +1     
- Partials      147      148       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct force-pushed the fix/export-wins-migration-3 branch from d9950f6 to 2462763 Compare May 15, 2024 12:11
@elcct elcct merged commit 085a93a into main May 15, 2024
2 checks passed
@elcct elcct deleted the fix/export-wins-migration-3 branch May 15, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants