Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to update legacy wins totals. #5763

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Nov 4, 2024

Description of change

This adds a command that will let us update legacy Export wins totals from given spreadsheet.

This PR also ensures that the totals will not be recalculated for legacy Export wins.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner November 4, 2024 12:58
Copy link
Contributor

@dredmonds dredmonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (392df95) to head (a4fee36).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5763   +/-   ##
=======================================
  Coverage   96.40%   96.41%           
=======================================
  Files        1026     1027    +1     
  Lines       24450    24472   +22     
  Branches     2213     2217    +4     
=======================================
+ Hits        23572    23594   +22     
  Misses        709      709           
  Partials      169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct force-pushed the feature/migrate-legacy-wins-totals branch from d038270 to a4fee36 Compare November 4, 2024 16:59
@elcct elcct merged commit 6566a18 into main Nov 4, 2024
5 checks passed
@elcct elcct deleted the feature/migrate-legacy-wins-totals branch November 4, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants