TET-880: Use secure cookie flag everywhere #5956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
https://uktrade.atlassian.net/browse/TET-880
The Django admin messages contrib module takes it's cookie settings from the general Django config. The SESSION_COOKIE_SECURE setting defaults to off, which means the messages cookies were also being created with the flag off, for example in the request below. This was flagged in the most recent pen test. e.g.:
POST http://localhost:8000/admin/company/advisor/f4a33f93-6303-4a7e-a813-ab4c204df2e3/change/
Before:

After:

Checklist
Has this branch been rebased on top of the current
main
branch?Explanation
The branch should not be stale or have conflicts at the time reviews are requested.
Is the CircleCI build passing?
General points
Other things to check
fixtures/test_data.yaml
is maintained when updating modelsSee docs/CONTRIBUTING.md for more guidelines.