Bugfix/tet 981 stova ingestion data #5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeanElliott96
force-pushed
the
bugfix/TET-981-stova-ingestion-data
branch
from
794dd8c to
82d6275
Compare
DeanElliott96
force-pushed
the
bugfix/TET-981-stova-ingestion-data
branch
from
82d6275 to
83ad352
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5967 +/- ##
==========================================
- Coverage 96.67% 96.66% -0.02%
==========================================
Files 1079 1080 +1
Lines 25383 25390 +7
Branches 1675 1676 +1
==========================================
+ Hits 24538 24542 +4
- Misses 690 693 +3
Partials 155 155 ☔ View full report in Codecov by Sentry. |
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
oliverjwroberts
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Matching model closer to prod Stova data model.
Also a fix to skip Stova Attendees who have empty company names.
Checklist
mainbranch?