Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ViewSet attribute to invoke filtersets #1112

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

rafa-garcia
Copy link
Contributor

django-filter renamed ViewSet.filter_class to ViewSet.filterset_class some time ago. The deprecated attribute name remained valid until v22 but now results in filters not being applied.

To do:

  • Change has a jira ticket that has the correct status.
  • Changelog entry added.

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 97.39% // Head: 97.39% // No change to project coverage 👍

Coverage data is based on head (77e9aeb) compared to base (37fb10e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1112   +/-   ##
========================================
  Coverage    97.39%   97.39%           
========================================
  Files          132      132           
  Lines         4675     4675           
========================================
  Hits          4553     4553           
  Misses         122      122           
Impacted Files Coverage Δ
company/views.py 99.59% <100.00%> (ø)
...management/commands/import_metadata_source_data.py 100.00% <100.00%> (ø)
dataservices/views.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ecbm ecbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafa-garcia rafa-garcia merged commit 1ae0d48 into develop Jan 24, 2023
@rafa-garcia rafa-garcia deleted the KLS-348-fix-market-guides-filters-by-country branch January 24, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants