This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Fix filters not preserved when paginated #103
Merged
+237
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pagination is now better covered by the filters tests.
ian-leggett
reviewed
May 15, 2020
web-bert
reviewed
May 15, 2020
ian-leggett
approved these changes
May 15, 2020
web-bert
approved these changes
May 15, 2020
|
|
||
| const testResults = (assert, expectedTotal, testPages) => { | ||
| context('Results', () => { | ||
| it('Total', () => |
There was a problem hiding this comment.
Ideally this should read as a sentence, "it total" is a bit vague
| }) | ||
|
|
||
| pages.slice(0, -1).reverse().forEach(itemsPerPage => | ||
| it('Previous', () => { |
There was a problem hiding this comment.
Ideally this should read as a sentence
| ) | ||
|
|
||
| pages.slice(1).forEach(itemsPerPage => | ||
| it('Next', () => { |
There was a problem hiding this comment.
Ideally this should read as a sentence
|
|
||
| assertResults(() => {}, Object.keys(ENQUIRIES).length) | ||
| const testPagination = ({ filters, totalPages, pages }) => | ||
| it(`Filters should be preserved on pagination`, () => { |
There was a problem hiding this comment.
Ideally this should read as a sentence
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when filters were reset when the user clicked on the numbered pagination links.