This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Update specific investment programme payload field #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverjwroberts
requested review from
cgsunkel,
marijnkampf,
p3dr0migue1,
DeanElliott96 and
bau123
as code owners
…of IDs This is due to recent changes to the field in Data Hub API, which is now a many-to-many relationship.
oliverjwroberts
force-pushed
the
hotfix/update-specific-investment-programme-payload-field
branch
from
6f279ed to
2ac9df2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
==========================================
- Coverage 69.07% 69.03% -0.04%
==========================================
Files 61 61
Lines 2024 2025 +1
==========================================
Hits 1398 1398
- Misses 626 627 +1 ☔ View full report in Codecov by Sentry. |
elcct
approved these changes
Jul 18, 2024
cgsunkel
approved these changes
Jul 18, 2024
oliverjwroberts
deleted the
hotfix/update-specific-investment-programme-payload-field
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Due to recent changes to the
specific_programmefield in Data Hub API (converted from foreign key to many-to-many and renamed), the field requirements in the payload that EMT sends to DataHub when creating an investment project have changed. Currently, the integration is broken and the specific programme is not recorded in the created project.This PR applies these changes to ensure that created investment projects will record the specific investment programme data.
Test instructions
If you create an enquiry in EMT, the enquiry's specific investment programme should now be visible in the created Data Hub investment project.