UAT release #2380
Merged
UAT release #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment this endpoint does nothing
Users can bulk approve multiple cases and we create approve recommendation for all those cases.
Initially only allowed for MoD teams
This is to make it easier to include Bulk approval audit events in notes and timeline.
Bulk approval audit event is not specific to a particular case hence filter them separately and combine into the case activity events.
A team can have multiple queues and we want to enable for specific queues instead of all queues of that team.
Following review comments it is updated to emit event for each case. This avoids special code to extract and combine these events to show in notes and timeline. This also helps to examine payload and identify relevant events for the special code to work.
Following review comments we now use a serializer to validate input data before transforming the data to contruct Advice records. This will ensure the API contract is enforced and validated with serializer.
This is repeated in few places so best to keep in the model.
This reverts commit 7e9b4ec.
This reverts commit 9cff9da.
The test takes a case that is assigned to an OGD queue and moves it forward. To be able to verify that the current queue is unassigned and next queue as per routing rules is assigned correctly the case is initially processed through product assessments and pre-circ. This is to prevent triggering of fallback routing rules which otherwise doesn't unassign the current queue and in addition routes to this fallback queue as this rules relies on presence of specific audit events. Though this verifies next queue as per routing rules this is not be considered a test for routing rules.
Add unit test for bulk approval permission
Update tests such that we cover queues of all teams that has bulk approval support and queues that don't support.
markj0hnst0n
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
LTD-