Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove unnecessary for loop when not encrypting #100

Closed

Conversation

michalc
Copy link
Member

@michalc michalc commented Jan 7, 2024

This remove an unnecesary intermediate for loop used when not encrypting / password protecting ZIPs

This remove an unnecesary intermediate for loop used when _not_ encrypting /
password protecting ZIPs
@michalc
Copy link
Member Author

michalc commented Jan 7, 2024

This won't working because the encryption function needs to call yield from _(chunk) to make sure that the current offset in the file is maintained

@michalc michalc closed this Jan 7, 2024
@michalc michalc deleted the perf/remove-unnecessary-iteration-no-encryption branch January 7, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant