Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1651 Fix sorting on list views #1380

Merged

Conversation

dalecannon
Copy link
Contributor

@dalecannon dalecannon commented Jan 10, 2025

TP2000-1651 Fix sorting on list views and tweak UI

Why

Filtered results on the list views are cleared if a user tries to sort a column in ascending or descending order.

What

Sorting and filtering

  • Adds common utility function to return the resolved URL of the current request
  • Adds capability to SortingMixin to build sorting URLs for use with create_sortable_anchor while preserving other query params such as those used for filtering
  • Updates usage of create_sortable_anchor in line with the changes to SortingMixin

Other changes that have become less relevant given the upcoming redesign:

List and detail views

  • Truncates long descriptions on list views
  • Removes current workbasket breadcrumb
  • Uses “-” in place of “None” when dereferencing null categories

Task detail view

  • Adds a title caption to Indicate if task is a subtask
  • Displays the parent task of a subtask

Task template detail and create views

  • Adds a ‘Return to workflow template’ button

Screenshots

Detail view of a subtask

Screenshot 2025-01-15 at 14 28 36

Return to workflow template button

Screenshot 2025-01-15 at 14 31 31

Checklist

  • Requires migrations? No
  • Requires dependency updates? No

@dalecannon dalecannon force-pushed the TP2000-1651--fix-sorting-and-tweak-ui branch 2 times, most recently from 058dbcb to 34d011a Compare January 10, 2025 14:04
@dalecannon dalecannon force-pushed the TP2000-1651--fix-sorting-and-tweak-ui branch from 34d011a to aa892fe Compare January 10, 2025 14:13
@dalecannon dalecannon marked this pull request as ready for review January 15, 2025 14:34
@dalecannon dalecannon requested a review from a team as a code owner January 15, 2025 14:34
@dalecannon dalecannon changed the title TP2000-1651 Fix sorting on list view and tweak UI TP2000-1651 Fix sorting on list views Feb 11, 2025
@dalecannon dalecannon merged commit 280ee81 into TP2000-1471--task-workflow Feb 13, 2025
@dalecannon dalecannon deleted the TP2000-1651--fix-sorting-and-tweak-ui branch February 13, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants