TP2000-143: 500 on Measure Detail view

measures/models.py

@@ -1,6 +1,7 @@
 from datetime import date
 from typing import Set
 
+from django.core.exceptions import ValidationError
 from django.db import models
 
 from common.business_rules import UpdateValidity
@@ -647,6 +648,8 @@ def save(self, *args, force_write=False, **kwargs):
                 instance = super().save(*args, force_write=force_write, **kwargs)
                 return self.copy(self.transaction)
 
+        self.full_clean()
+
         return super().save(*args, force_write=force_write, **kwargs)
 
     def diff_components(
@@ -697,6 +700,17 @@ def diff_components(
                     transaction=workbasket.new_transaction(),
                 )
 
+    def clean(self, *args, **kwargs):
+        duplicates = Measure.objects.approved_up_to_transaction(
+            self.transaction,
+        ).filter(sid=self.sid)
+        if self.version_group:
+            duplicates = duplicates.exclude(version_group=self.version_group)
+
+        if duplicates.exists():
+            raise ValidationError(f"Measure with sid {self.sid} already exists")
+        super().clean(*args, **kwargs)
+
 
 class MeasureComponent(TrackedModel):
     """Contains the duty information or part of the duty information."""

measures/tests/test_models.py

@@ -1,6 +1,7 @@
 from decimal import Decimal
 
 import pytest
+from django.core.exceptions import ValidationError
 
 from common.tests import factories
 from common.validators import UpdateType
@@ -425,3 +426,15 @@ def test_diff_components_delete(
 
     assert deleted.exists()
     assert deleted.first().transaction == workbasket.current_transaction
+
+
+def test_measure_with_duplicate_sid_raises_error():
+    """Check that creating a new version doesn't raise an error and that error
+    is raised when version_group differs."""
+    model = factories.MeasureFactory.create()
+    model.new_version(model.transaction.workbasket)
+
+    with pytest.raises(ValidationError) as err:
+        factories.MeasureFactory.create(sid=model.sid)
+
+    assert f"Measure with sid {model.sid} already exists" in err.value.messages