Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

copy-to-clipboard #1039

Merged
merged 9 commits into from
Jul 5, 2019
Merged

copy-to-clipboard #1039

merged 9 commits into from
Jul 5, 2019

Conversation

Mboulianne
Copy link
Contributor

@Mboulianne Mboulianne commented Jun 20, 2019

@ulaval/modul-components

PR Checklist

  • Provide a small description of the changes introduced by this PR
    Make a component which allows copying a value from a button click
  • Include links to issues
    https://jira.dti.ulaval.ca/browse/MODUL-1110
  • Openshift deployment requested
  • Include this section in the release notes
  • Other info

@Mboulianne Mboulianne requested a review from chuckmah as a code owner June 20, 2019 19:06
@Mboulianne
Copy link
Contributor Author

Pour le moment le visuel est pas sur la coche.. mais j'aimerais quand même que ça puisse petre mergé afin qu'on puisse l'utiliser.

@Atiomi va s'occuper de faire l'intégration d'ici 1 mois.

<template slot="button" slot-scope="{ handlers }">
<m-button v-on="handlers" skin="secondary">Custom Copy Button</m-button>
</template>
</${componentName}>`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est possible de customizer l'expérience facilement comme montré si haut. Le input doit implémenter l'interface CopyToClipboardInputSupport et gérer l'évènement click.

Le bouton doit gérer l'évènement click et l'évènement mousedown.

@Mboulianne Mboulianne requested review from Atiomi and Netnix June 21, 2019 15:17
@Mboulianne Mboulianne added the new feature New component, directive or filter label Jun 27, 2019
@Mboulianne Mboulianne force-pushed the feature/copy-to-clipboard branch from bbc8b6b to fdf050e Compare June 27, 2019 18:39
@Mboulianne Mboulianne force-pushed the feature/copy-to-clipboard branch from 9e9bc29 to 61a62f7 Compare July 3, 2019 12:20
@Mboulianne Mboulianne added this to the 1.0.0-beta.111 milestone Jul 3, 2019
@jipigi jipigi self-requested a review July 4, 2019 19:15
Copy link
Contributor

@jipigi jipigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

À valider avec JPM ou Marie, mais l'idée est là ;)

@Mboulianne Mboulianne force-pushed the feature/copy-to-clipboard branch from 849e96f to d590205 Compare July 5, 2019 11:34
@chuckmah chuckmah merged commit fb43dfe into develop Jul 5, 2019
@chuckmah chuckmah deleted the feature/copy-to-clipboard branch July 5, 2019 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new feature New component, directive or filter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants