-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt shown even when expected to be disable. #117
Comments
rugeGerritsen
added a commit
to rugeGerritsen/zephyr
that referenced
this issue
Mar 15, 2022
Uses the proposed workaround in ulfalizer/Kconfiglib#117 Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
carlescufi
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this issue
Mar 31, 2022
Uses the proposed workaround in ulfalizer/Kconfiglib#117 Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
coreboot-org-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this issue
Mar 31, 2022
Uses the proposed workaround in ulfalizer/Kconfiglib#117 Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no> GitOrigin-RevId: 8649eb1 Change-Id: I422eb6d09d9bfdbcfff19bcbc462f8132ebe2393 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/3562860 Tested-by: CopyBot Service Account <copybot.service@gmail.com> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org> Tested-by: Keith Short <keithshort@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem description
When a symbol is double defined but with different prompts, where the active prompt is depending on a common setting both prompts may show.
For example to indicate to users that a given setting is
EXPERIMENTAL
under some circumstances, one prompt is shown whenFOO
is enabled also, and the other prompt is shown whenFOO
is disabled.This happens when configs right below the second symbol is guarded (
depends on
) with anif
.Code that reproduces this:
As expected
Unexpected, both prompts are now shown:
Expected behavior
Only a sing prompt should be shown when
FOO=n
andBAR=y
Workaround
Add a
DUMMY
config between the lastconfig
and theif
, like this:Almost as before:
Now working as expected:
Cons on the workaround
BAZ
setting is no longer indented as it is no longer seen as a submenu toBAR
.Additional info
This code is believed to be responsible for the observed behavior:
Kconfiglib/menuconfig.py
Lines 1504 to 1513 in 061e71f
The text was updated successfully, but these errors were encountered: