Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suds-jurko timeout support in cuahsi/wof #155

Closed
rajadain opened this issue Jun 5, 2018 · 5 comments
Closed

Add suds-jurko timeout support in cuahsi/wof #155

rajadain opened this issue Jun 5, 2018 · 5 comments

Comments

@rajadain
Copy link

rajadain commented Jun 5, 2018

Hello,

I'm a developer for https://github.com/WikiWatershed/model-my-watershed. While working with Ulmo, at times we've felt the need to specify a custom timeout (opposed to the default 90s). suds-jurko supports timeouts for both the http and https modules. It would be great if they could be surfaced in the Ulmo API, just as caching currently is.

Without it, we have to wrap it in a timeout decorator, which is fine for now, but limits us to single-threaded work, since it cannot handle non-pickleable responses in multithreaded environments. This wrapping is extraneous since suds does have timeout support, it's just hidden from use.

Thanks.

@emiliom
Copy link
Contributor

emiliom commented Jun 5, 2018

Thanks @rajadain. To give more context and details: I've been working with @rajadain on the broader project that uses the ulmo cuahsi/wof reader. We'll probably submit a couple of commits in the near future addressing some issues, including the one @rajadain describes here.

@emiliom
Copy link
Contributor

emiliom commented Jun 5, 2018

I suggest the title of this issue be renamed to "Add suds-jurko timeout support in cuahsi/wof". I don't have permission to change it.

@rajadain rajadain changed the title Add timeout support Add suds-jurko timeout support in cuahsi/wof Jun 5, 2018
@dharhas
Copy link
Contributor

dharhas commented Jun 6, 2018

If y'all submit a pull request, ideally with a few tests, I can merge it in. I don't actively use the cuahsi/wof plugin.

@emiliom
Copy link
Contributor

emiliom commented Feb 5, 2019

Addressed in PR #165. Closing.

@emiliom
Copy link
Contributor

emiliom commented Feb 5, 2019

Ah. I forgot I didn't open this issue, so I can't close it! @dharhas, you can close this issue any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants