CUAHSI WaterML parsing and WOF/suds request enhancements #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default suds timeout value (90 seconds) was being used. This optional parameter will give users more control. Added to all get_* calls in cuahsi/wof/core.py
This was referenced Jan 30, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits adding:
timeoutparameter, giving users more control. Addresses Add suds-jurko timeout support in cuahsi/wof #155. I tested it "manually" (Python 3.6), but not sure how to create a test using the existing suds + mock tests. Plus, as mentioned in State of ulmo #161, "Unfortunately, there are currently many test failures due to changes in various upstream websites", so I'm not sure how to proceed.Also threw in a commit with a small update to
.gitignore