Bug fix for NASA ORNL Daymet weather?

[emiliom]

@talbertc-usgs Last November you made this comment on another issue:

I just happened to have found a bug caused by a change in the service for NASA ORNL's Daymet. It's an easy fix. If Ulmo will be continuing I can submit a pr.

@dharhas is moving quickly on a new ulmo release that incorporates several bug fixes and small improvements. It'd be really great if you could submit a PR for the ORNL Daymet bug fix you mentioned, so it can be part of this new release!

I don't actually use Daymet, so I have nothing to contribute other than this housekeeping. BTW, the link to Daymet on the ulmo docs is broken. Should it just point to the Daymet home page, https://daymet.ornl.gov ?

[dharhas]

I think I fixed the bug in 78094c4, at least the tests pass now. I did not fix the docs issue.

[emiliom]

Great!

[ColinTalbert]

Hello Emilio, Hopefully it's not too late. I'll see if I can get a pr put together.

…

-- Colin Colin Talbert Data Manager, Analyst and Developer US Geological Survey, Fort Collins Science Center 2150 Centre Ave. Bldg. C Fort Collins, CO 80526 (970) 226-9425 http://orcid.org/0000-0002-9505-1876 Work schedule: Monday, Thursday - 7:00 - 5:00 Tuesday - Wednesday - 7:00 - 3:10 Friday (Telework) - 7:00 - 5:00

On Tue, Feb 5, 2019 at 12:33 PM Emilio Mayorga ***@***.***> wrote: @talbertc-usgs <https://github.com/talbertc-usgs> Last November you made this comment <#161 (comment)> on another issue: I just happened to have found a bug caused by a change in the service for NASA ORNL's Daymet. It's an easy fix. If Ulmo will be continuing I can submit a pr. @dharhas <https://github.com/dharhas> is moving quickly on a new ulmo release that incorporates several bug fixes and small improvements. It'd be really great if you could submit a PR for the ORNL Daymet bug fix you mentioned, so it can be part of this new release! I don't actually use Daymet, so I have nothing to contribute other than this housekeeping. BTW, the link to Daymet on the ulmo docs <https://ulmo.readthedocs.io/en/latest/api.html#module-ulmo.nasa.daymet> is broken. Should it just point to the Daymet home page, https://daymet.ornl.gov ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#166>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWHganWlTW1cINUV0NNB5E4NSvM4yrSxks5vKdxxgaJpZM4aj6xt> .

[dharhas]

@talbertc-usgs have a look at the fix I made. It may or may not be the same one that you found.

[ColinTalbert]

It looks like @dharhas already put in a fix for this. Thanks for your work on this project. Thanks, Colin Colin Talbert Data Manager, Analyst and Developer US Geological Survey, Fort Collins Science Center 2150 Centre Ave. Bldg. C Fort Collins, CO 80526 (970) 226-9425 http://orcid.org/0000-0002-9505-1876 Work schedule: Monday, Thursday - 7:00 - 5:00 Tuesday - Wednesday - 7:00 - 3:10 Friday (Telework) - 7:00 - 5:00

…

On Tue, Feb 12, 2019 at 7:53 AM Talbert, Colin ***@***.***> wrote: Hello Emilio, Hopefully it's not too late. I'll see if I can get a pr put together. -- Colin Colin Talbert Data Manager, Analyst and Developer US Geological Survey, Fort Collins Science Center 2150 Centre Ave. Bldg. C Fort Collins, CO 80526 (970) 226-9425 http://orcid.org/0000-0002-9505-1876 Work schedule: Monday, Thursday - 7:00 - 5:00 Tuesday - Wednesday - 7:00 - 3:10 Friday (Telework) - 7:00 - 5:00 On Tue, Feb 5, 2019 at 12:33 PM Emilio Mayorga ***@***.***> wrote: > @talbertc-usgs <https://github.com/talbertc-usgs> Last November you made this > comment > <#161 (comment)> on > another issue: > > I just happened to have found a bug caused by a change in the service for > NASA ORNL's Daymet. It's an easy fix. If Ulmo will be continuing I can > submit a pr. > > @dharhas <https://github.com/dharhas> is moving quickly on a new ulmo > release that incorporates several bug fixes and small improvements. It'd be > really great if you could submit a PR for the ORNL Daymet bug fix you > mentioned, so it can be part of this new release! > > I don't actually use Daymet, so I have nothing to contribute other than > this housekeeping. BTW, the link to Daymet on the ulmo docs > <https://ulmo.readthedocs.io/en/latest/api.html#module-ulmo.nasa.daymet> > is broken. Should it just point to the Daymet home page, > https://daymet.ornl.gov ? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#166>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AWHganWlTW1cINUV0NNB5E4NSvM4yrSxks5vKdxxgaJpZM4aj6xt> > . >

[emiliom]

Great! Closing this issue.