Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usace swtwc #149

Merged
merged 10 commits into from
Mar 24, 2019
Merged

Fix usace swtwc #149

merged 10 commits into from
Mar 24, 2019

Conversation

solomon-negusse
Copy link
Member

usace.swtwc data format has changed. this updates the scraper and tests for it.

@solomon-negusse
Copy link
Member Author

not ready for merging

@dharhas
Copy link
Contributor

dharhas commented Feb 8, 2018

@solomon-negusse you still working on this fix?

@solomon-negusse
Copy link
Member Author

Hey Dharhas, this fell off my radar as I'm getting the data from USGS at this time. I plan to finish it up at some at some point though.
Also, past few days I have been working on new groundwater dcp (satellite) data parser that will go into the usgs.eddn module and I'll submit a new PR for that next week.

@dharhas
Copy link
Contributor

dharhas commented Feb 4, 2019

@solomon-negusse are you still working on this or should I close the PR?

@solomon-negusse
Copy link
Member Author

hey @dharhas i haven't finished this. the module in master is broken now so if we want to keep it, i'll have to finish this fix. i'm getting the same data from nwis so this PR got neglected but can work on it later in the week.

@dharhas
Copy link
Contributor

dharhas commented Feb 5, 2019

I made some small changes to the tests and got them to pass. Basically older data doesn't seem to be available any more. I'm didn't hit whatever error you were trying to fix in the date format. Also I've completely disabled mocking tests (except for eddn) accross all modules because they aren't very useful anymore unless we update all the stored files.

@emiliom
Copy link
Contributor

emiliom commented Mar 24, 2019

@solomon-negusse thanks for the follow ups yesterday! I can see that the mock test test/usace_swtwc_test.py::test_get_station_data is the only usace_swtwc test that's still failing, as you mentioned in #168 and #169.

I'm merging this PR.

@solomon-negusse
Copy link
Member Author

thanks @emiliom!

@emiliom emiliom deleted the fix-usace-swtwc branch September 2, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants