-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix usace swtwc #149
Fix usace swtwc #149
Conversation
not ready for merging |
@solomon-negusse you still working on this fix? |
Hey Dharhas, this fell off my radar as I'm getting the data from USGS at this time. I plan to finish it up at some at some point though. |
@solomon-negusse are you still working on this or should I close the PR? |
hey @dharhas i haven't finished this. the module in master is broken now so if we want to keep it, i'll have to finish this fix. i'm getting the same data from nwis so this PR got neglected but can work on it later in the week. |
I made some small changes to the tests and got them to pass. Basically older data doesn't seem to be available any more. I'm didn't hit whatever error you were trying to fix in the date format. Also I've completely disabled mocking tests (except for eddn) accross all modules because they aren't very useful anymore unless we update all the stored files. |
@solomon-negusse thanks for the follow ups yesterday! I can see that the mock test test/usace_swtwc_test.py::test_get_station_data is the only usace_swtwc test that's still failing, as you mentioned in #168 and #169. I'm merging this PR. |
thanks @emiliom! |
usace.swtwc
data format has changed. this updates the scraper and tests for it.