fix for issue 159. ncdc ghcn_daily.get_data failed with error #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneshorak
changed the title
|
@johanneshorak thanks. I'll try and get this merged in soon. |
|
As a quick FYI, I just came across this same issue. This is to say that your work is valuable and I hope you get it up and running again soon! Happy to try to help as well though I don't know the ulmo code base. |
|
I have applied @johanneshorak's hotfix locally and it has solved my problems with Ulmo. I suggest it be implemented soon, even if it is not the ultimate solution that the core devs would like, in order to get everything up and running again -- thanks! |
This was referenced Feb 1, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time pull request ever. This is a fix(?) to issue 159.
The method
ncdc.ghcn_daily.get_data()failed due to changes in how resampling is handled by pandas. There are different ways to fix this issue, the quickest seemed to just supply how the timeseries should be resampled, leading to the actual generation of the resampled index - which is all that is needed to get the code working again.