Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

be able to retrieve iv data prior to 2007 with period='all' kwarg #181

Merged
merged 1 commit into from
Jan 7, 2020
Merged

be able to retrieve iv data prior to 2007 with period='all' kwarg #181

merged 1 commit into from
Jan 7, 2020

Conversation

solomon-negusse
Copy link
Member

Fixes #175. Moved earliest iv start date back to 1910 based on recommendation from Jim (USGS).

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 8728498 on fix-nwis-iv-start-date into 0cca702 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 8728498 on fix-nwis-iv-start-date into 0cca702 on master.

@emiliom
Copy link
Contributor

emiliom commented Jan 7, 2020

Thank you @solomon-negusse !! As you may have seen I'm on working on a new 0.8.6 release, and had included #175 as a fix in my milestone.

I won't close #175 just yet.

@emiliom emiliom merged commit 6f7a685 into master Jan 7, 2020
@emiliom emiliom mentioned this pull request Jan 7, 2020
Merged
@solomon-negusse
Copy link
Member Author

That sounds good @emiliom. Thanks for the recent updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nwis get_site_data with service='iv' and period='all' sets an inappropriately recent start date
3 participants
@solomon-negusse @coveralls @emiliom