Thousands separators #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires limiting the Python versions used, as these were not added until more recent version of Python.
|
Sorry about the CI failure. I don't think they are a result of my changes, but I'm willing to learn.
|
PeterShinners
commented
Jul 25, 2020
| assert new_result == '42,042.042' | ||
|
|
||
|
|
||
| @pytest.mark.skipif(sys.version_info < (3, 6), reason="Requires Python 3.6") |
There was a problem hiding this comment.
Since these changes more recent version of Python, I added a pytest.mark to skip the unsupported versions. If you would prefer a different way of conditionally running tests, let me know.
|
I had no luck running
|
|
FYI, see Issue #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python added support for formatting numbers with thousands separators. This works for both floating point and integer numbers. Originally the comma separator was added. In Python 3.6, support for underscore was also added.