Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan if in memory is too much #38

Open
AnatolyBuga opened this issue Nov 13, 2022 · 2 comments · Fixed by #49
Open

scan if in memory is too much #38

AnatolyBuga opened this issue Nov 13, 2022 · 2 comments · Fixed by #49
Assignees
Labels
enhancement New feature or request

Comments

@AnatolyBuga
Copy link
Member

AnatolyBuga commented Nov 13, 2022

It's possible clients will have too much data to hold it in memory all the time. For such usecases we can try to provide an option for lazy scans, leveraging on with_streaming.

Pros:

  1. No in memory frame

Cons:

  1. Performance will be impacted significantly because reading, assigning weights, has to happen per request.
@AnatolyBuga AnatolyBuga changed the title scan instead of in memory scan if in memory is too much Nov 13, 2022
@AnatolyBuga
Copy link
Member Author

Step 1: Make execute funtion lazy from start to finish
c4dbed6

@AnatolyBuga AnatolyBuga self-assigned this Nov 14, 2022
@AnatolyBuga AnatolyBuga added the enhancement New feature or request label Nov 14, 2022
AnatolyBuga added a commit that referenced this issue Nov 17, 2022
…s only. This is to allow streaming feature on driver. If not cfg streaming then thoe LazyFrame will be collected
This was referenced Nov 17, 2022
@AnatolyBuga AnatolyBuga reopened this Nov 19, 2022
@AnatolyBuga
Copy link
Member Author

When streaming atm UI wouldn't allow to override "prepared" columns such as risk weight. Perhaps add an overridable method to the DataSet trait which would return Vec of added overridable columns.

@AnatolyBuga AnatolyBuga reopened this Nov 19, 2022
AnatolyBuga added a commit that referenced this issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant