Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reddit social icon #65

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Add Reddit social icon #65

merged 3 commits into from
Aug 12, 2024

Conversation

Y-T-G
Copy link
Contributor

@Y-T-G Y-T-G commented Aug 8, 2024

Downloaded from FontAwesome.

@glenn-jocher
Copy link
Member

@Y-T-G @Burhan-Q thanks guys! We need to use the "Dark Blue" color for all logos from https://www.ultralytics.com/brand, this one will stick out with the wrong color as is currently.

Please update the logo with the color from the brand page. Thank you!

@glenn-jocher
Copy link
Member

Hex is #111F68

https://www.ultralytics.com/brand
Screenshot 2024-08-08 at 18 47 40

@Y-T-G
Copy link
Contributor Author

Y-T-G commented Aug 8, 2024

@glenn-jocher Alright, updated.

@Y-T-G
Copy link
Contributor Author

Y-T-G commented Aug 8, 2024

The other logos here aren't #111F68

image

The Reddit one:

image

@Burhan-Q
Copy link
Member

Burhan-Q commented Aug 8, 2024

I took a quick sample and looks like the correct color to match the majority of icons should be #0b23a9. I'm also seeing that the YouTube icon probably needs to get updated with the correct color as it's slightly different from the others. I also confirmed with another color picker that the values are consistent just b/c I wanted to be certain.

image
image
image
image
image

@glenn-jocher I'm going to assume all the icons should keep the #0b23a9 color and not use the #111F68 as they currently aren't using this. I'll assume that's the case unless hearing otherwise.

I'd guess the reason for this color (#0b23a9) is so that the icons will stand out more on dark mode, as the "Dark blue" color would make them less visible, but that's only my speculation. From the docs page in dark mode:

Using #0b23a9

image

Using #111F68

dark-icons

@glenn-jocher
Copy link
Member

glenn-jocher commented Aug 9, 2024

@Burhan-Q ah, good catch. Yes let's do the Reddit icon in #0b23a9 then for consistency.

@Burhan-Q
Copy link
Member

I see the icon has been updated to use #0b23a9 so I'm going to merge

@Burhan-Q Burhan-Q merged commit f87827d into ultralytics:main Aug 12, 2024
1 check passed
@glenn-jocher
Copy link
Member

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants