Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create format.yml #10

Merged
merged 10 commits into from
Apr 9, 2024
Merged

Create format.yml #10

merged 10 commits into from
Apr 9, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 9, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Automatic code formatting and documentation standards enforcement for Ultralytics Flutter app.

πŸ“Š Key Changes

  • πŸ”„ Introduced a new GitHub workflow (format.yml) for automatic code and documentation formatting in PRs.
  • πŸ› οΈ Minor spelling corrections in code comments and documentation across multiple files.
  • πŸ“ Improved table formatting in README.md and removed redundant spaces and newlines in documentation files.

🎯 Purpose & Impact

  • πŸ“ˆ Enhanced Consistency & Readability: Automated formatting ensures that all code and documentation adheres to Ultralytics standards, making it easier to read and maintain.
  • πŸ” Reduced Errors: Spelling corrections and tidying up of documentation help reduce confusion or misunderstanding for developers and users alike.
  • πŸš€ Streamlined Contributions: With automatic formatting, contributors can focus more on the quality of their contributions rather than formatting, speeding up the review process and maintaining a high standard across the project.

Comment on lines 2754 to 2756
uint8_t ans[16] = {0};\
vsm(ans, vmslt(a, 0, vl), vl);\
return reinterpret_cast<int*>(ans)[0];\
uint8_t and[16] = {0};\
vsm(and, vmslt(a, 0, vl), vl);\
return reinterpret_cast<int*>(and)[0];\
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiossm this is the only spelling change that I see in actual code that might cause issues. Can you review if this is ok?

I don't see any other examples of a variable name ans anywhere in the code, so I'm assuming this is ok, but maybe to be safe you could re-write this variable with an actual name, i.e. answer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiossm I'm mergint this PR now to get this done, but please update these 3 variables if needed in a separate PR.

@glenn-jocher glenn-jocher requested a review from sergiossm April 9, 2024 10:32
@glenn-jocher glenn-jocher merged commit a397568 into main Apr 9, 2024
1 check passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch April 9, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants