Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format.yml #78

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Update format.yml #78

merged 1 commit into from
Dec 7, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Dec 7, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Updated the GitHub Actions workflow to adjust how pull request events are handled. πŸ”„

πŸ“Š Key Changes

  • Modified the GitHub workflow (format.yml) to replace pull_request_target with pull_request.
  • Updated the monitored pull request event types to include opened, closed, synchronize, and review_requested.

🎯 Purpose & Impact

  • Purpose: Simplifies and enhances workflow security by switching from pull_request_target to pull_request, reducing potential risks. πŸ”’
  • Impact: Ensures more accurate and secure handling of PR events, improving automation and reliability during code reviews or updates. πŸš€

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Dec 7, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/yolo-flutter-app πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolo-flutter-app main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For more guidance, please refer to our Contributing Guide.

P.S. This is an automated response to help streamline the review process, but an Ultralytics engineer will be with you shortly to assist further πŸš€βœ¨ Don’t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🌟

@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/yolo-flutter-app πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your change in your PR description, and link to any relevant issues if applicable. Ensure your commit messages are clear, concise, and follow the project guidelines.
  • βœ… Synchronize with Source: Verify your PR is synchronized with the main branch of ultralytics/yolo-flutter-app. If it's outdated, update it using the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Confirm all Ultralytics Continuous Integration (CI) checks have passed. If there are failures, please review and resolve them.
  • βœ… Update Documentation: Update the relevant documentation for your changes if they impact how users interact with the app or repository.
  • βœ… Add Tests: Include or update tests as needed to cover your changes, and verify that all tests pass successfully.
  • βœ… Sign the CLA: If this is your first Ultralytics PR, please sign the Contributor License Agreement (CLA) by leaving a comment saying "I have read the CLA Document and I sign the CLA".
  • βœ… Minimize Changes: Ensure only necessary changes are included in this PR. "Simplicity is the ultimate sophistication." β€” Leonardo da Vinci

For more information on our contribution process, please refer to the Contributing Guide. 🌟

⚠️ If your PR fixes a bug or introduces a specific feature: Please ensure a minimum reproducible example (MRE) or clear use case is provided in the description for our team to better understand and verify your changes.

Thank you for contributing to the Ultralytics yolo-flutter-app repository! An Ultralytics engineer will review your PR soon. If you have any questions or concerns, feel free to drop a comment here. πŸš€

@glenn-jocher glenn-jocher merged commit 6b186d1 into main Dec 7, 2024
5 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch December 7, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants