-
-
Notifications
You must be signed in to change notification settings - Fork 16.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translucent line for visibility #12610
base: master
Are you sure you want to change the base?
Conversation
@mucunwuxian hello! 👋 Thank you so much for your kind words and for your contribution to the YOLOv5 project! It's fantastic to see community members like yourself getting involved. 😊 Regarding your PR for adding a translucent bounding box line argument, that sounds like a potentially useful feature for improving result visualization. Please make sure to detail the changes in your PR description, including any new argument options and how they affect the output. This will help us understand and review your contribution more effectively. Don't forget to link any related issues as mentioned, and if you haven't already, please sign the CLA to move forward with the contribution process. Looking forward to reviewing your PR, and once again, thanks for supporting the YOLOv5 community! 🚀 |
@glenn-jocher I added comments. |
Hello @mucunwuxian! 👋 Great to hear that you've added comments to your PR. 👍 To ensure everything is in order, please double-check the following:
If all these points are covered and your PR is linked to the issue you created, there shouldn't be any shortage in your submission. Once everything looks good, we'll proceed with the review process. Thank you for your diligence and for contributing to YOLOv5! 🌟 |
@glenn-jocher There are only a few code changes. It seems that the line break was added by the autocorrect function. I think it will be more intuitive and user-friendly! |
Hello again @mucunwuxian! 😄 It's great to hear that the code changes are minimal and you've considered the user experience. If the autocorrect function has introduced unintended line breaks, it's a good idea to review and clean up the formatting before finalizing the PR. Clean and readable code is always appreciated! Once you've made sure the appearance and functionality align with your intentions, we'll be happy to review it. Your efforts to make YOLOv5 more intuitive and user-friendly are very much appreciated! Looking forward to your PR, and thank you for being proactive in enhancing the project! 🌟 |
@glenn-jocher After arranging the appearance, I ran the automatic PR check again.👍 |
Hello @mucunwuxian, Fantastic! Thank you for tidying up the appearance and rerunning the automatic checks. 👍 I'll take a look at the contents of your PR as soon as possible. Your proactive approach is greatly appreciated, and it's contributors like you who help make YOLOv5 better for everyone. Thanks again for your contribution! 🌟 |
Hi, @glenn-jocher |
Hello @mucunwuxian, Thank you for checking in! At this point, if you've ensured that your PR is complete with all necessary information and passes all checks, there's nothing more you need to do for now. I'll review your PR and get back to you with any feedback or if any further actions are required on your end. Your patience and willingness to help are much appreciated! 😊 If you have any other questions or additional contributions, feel free to share them. Have a great day! |
I have read the CLA Document and I sign the CLA 2 out of 3 committers have signed the CLA. |
Thank you 🙏 for your contribution to Ultralytics 🚀! Your effort in enhancing our repositories is greatly appreciated. To streamline the process and assist us in integrating your Pull Request (PR) effectively, please follow these steps:
-> I checked that there are no similar PRs.
-> I created an issue. #12612
-> I added an argument to make the bounding box line translucent to improve visibility of results.
How about this?
Ultralytics Contributor License Agreement (CLA): To uphold the quality and integrity of our project, we require all contributors to sign the CLA. Please confirm your agreement by commenting below:
I have read the CLA Document and I hereby sign the CLA
-> I have read the CLA Document and I hereby sign the CLA.
For more detailed guidance and best practices on contributing, refer to our ✅ Contributing Guide. Your adherence to these guidelines ensures a faster and more effective review process.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
📊 Key Changes
numpy
library to manipulate image data.line_alpha
for bounding box transparency in thedetect.py
script.🎯 Purpose & Impact
The purpose of introducing
line_alpha
is to enhance the visibility of detection results by making the bounding boxes translucent. This change can help users discern background details that might be important for context without compromising the visibility of the bounding box itself. The impact is improved visual analysis for the user, especially in situations where seeing the background information is just as critical as seeing the object detections.🌟 Summary
Introducing 🔎 translucent bounding boxes in Ultralytics' YOLOv5 for better visibility and context during object detection.