Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commiting changes in yolov5_drive submodule #13489

Closed
wants to merge 2 commits into from

Conversation

radheughreja
Copy link

@radheughreja radheughreja commented Jan 11, 2025

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

This PR streamlines multiline error messages in assert statements for better readability and code consistency.

πŸ“Š Key Changes

  • Reformatted multiline assert error messages across certain files (general.py, clearml_utils.py, torch_utils.py) by shifting arguments into a cleaner multi-line style.
  • Ensured the updated assert statements maintain the same logic with formatted error strings.

🎯 Purpose & Impact

  • Purpose: Improves code readability and maintainability, making error messages easier to comprehend and less cluttered.
  • Impact: Developers can identify issues more clearly during debugging, leading to a smoother development experience without functionality changes.

Copy link
Contributor

github-actions bot commented Jan 11, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I sign the CLA


1 out of 2 committers have signed the CLA.
βœ… (UltralyticsAssistant)[https://github.com/UltralyticsAssistant]
❌ @radheughreja
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@UltralyticsAssistant UltralyticsAssistant added bug Something isn't working enhancement New feature or request labels Jan 11, 2025
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @radheughreja, thank you for submitting a πŸš€ PR to the ultralytics/yolov5 repository! We appreciate your contribution. Here's a checklist to help streamline the review process:

  • βœ… Define a Purpose: Please ensure your PR description provides clear context and outlines the purpose of your changes. If available, link any related issues here. Commit messages should be concise and aligned with project standards.
  • βœ… Synchronize with Main: Make sure your PR is up to date with the latest changes from the main branch of ultralytics/yolov5. Click the 'Update branch' button or run git pull and git merge main locally.
  • βœ… Minimize Changes: Ensure that your changes are necessary and don't alter unrelated functionality to reduce review time and potential conflicts. "Simplicity is the ultimate sophistication." β€” Leonardo da Vinci
  • βœ… Pass CI Checks: Please verify that all Continuous Integration (CI) tests pass for your code. Address any failing checks seen in the GitHub Actions panel.
  • βœ… Update Documentation: If your changes introduce new features or impacts current functionality, make sure to update the documentation.
  • βœ… Include Tests: For new or modified functionality, include corresponding test cases and confirm that all tests pass.
  • βœ… Sign the CLA: If this is your first contribution, please sign our Contributor License Agreement (CLA) by commenting, "I have read the CLA Document and I sign the CLA."
  • βœ… Provide Context for Breaking Changes: As your PR deletes the dataloaders.py file and modifies script permissions, please specify in detail how these changes impact existing functionality. Additionally, if this removal is part of a migration to a new method or module, kindly direct reviewers to the replacement or alternative approaches. πŸ‘

🌟 Some areas to consider based on your PR:

  1. Removing utils/dataloaders.py: The file appears to include critical functions for data handling, augmentation, caching, and loading. Could you detail if this file’s contents are relocated elsewhere or if these features are deprecated? If users need alternative solutions, provide documentation or usage examples.
  2. Adjusting Permission Modes: Changing script permissions is an excellent step to increase security and maintain consistency, but ensure users can still execute scripts without friction when necessary. If additional setup steps are required, reflect this in the documentation updates.
  3. Breaking Change Label: Since this PR impacts existing functionalities, marking it as a breaking change to alert downstream developers may be necessary.

πŸ› οΈ If the changes cause any unforeseen bugs or errors or you're aware of edge cases we're missing, please provide a Minimum Reproducible Example (MRE) for testing to accelerate the review process.

For additional guidance, our Contributing Guide provides a comprehensive overview of the contribution process.

Thank you for contributing to Ultralytics! An Ultralytics team member will review and assist shortly. ☺️

@glenn-jocher
Copy link
Member

@radheughreja closing as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants