Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalized mosaic plotting bug fix #1647

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Normalized mosaic plotting bug fix #1647

merged 1 commit into from
Dec 9, 2020

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Dec 9, 2020

This PR attempts to fix issue #1623. A tolerance is introduced to the normalization determination of labels, which previously accidentally classified labels as non-normalized due to numerical precision issues.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improved bounding box normalization tolerance in plotting utility.

📊 Key Changes

  • Adjusted the condition to check for normalized bounding box coordinates with a slight tolerance (from exactly 1 to 1.01).

🎯 Purpose & Impact

  • The update allows for small numerical inaccuracies when plotting normalized bounding box coordinates.
  • Users will benefit from more robust visualizations, especially when coordinates may not be perfectly normalized due to floating-point arithmetic limitations. 🎨✨

@glenn-jocher glenn-jocher linked an issue Dec 9, 2020 that may be closed by this pull request
@glenn-jocher
Copy link
Member Author

Problem solved! :)
train_batch2

@glenn-jocher glenn-jocher merged commit 84f9bb5 into master Dec 9, 2020
@glenn-jocher glenn-jocher deleted the plotting branch December 9, 2020 02:44
@glenn-jocher glenn-jocher self-assigned this Dec 9, 2020
burglarhobbit pushed a commit to burglarhobbit/yolov5 that referenced this pull request Jan 1, 2021
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

train_batch.jpg labels missing
1 participant