Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reveal more title items on the layout context #137

Closed
ultraq opened this issue Oct 1, 2016 · 1 comment
Closed

Reveal more title items on the layout context #137

ultraq opened this issue Oct 1, 2016 · 1 comment
Assignees
@ultraq
Labels
enhancement
Milestone
Thymeleaf Layout ...

Comments

@ultraq
Copy link
Owner

ultraq commented Oct 1, 2016

Currently the layout context only contains the resulting title. It'll be nice to include the other parts too, like the content and layout title(s).
@ultraq ultraq added this to the Thymeleaf Layout Dialect 2.1 milestone Oct 1, 2016
@ultraq
Copy link
Owner Author

ultraq commented Oct 1, 2016

This might also go some way to fixing the TODO here: https://github.com/ultraq/thymeleaf-layout-dialect/blob/master/Source/nz/net/ultraq/thymeleaf/decorators/html/HtmlTitleDecorator.groovy#L88-L92

ultraq added a commit that referenced this issue Nov 6, 2016
@ultraq
Fix for #137, set layout and content titles on layout context.
9aa18f2 
Also uses the standard context to pass around these title values so that
I'm not bleeding implementation detail on the DOM / Thymeleaf models.
ultraq added a commit that referenced this issue Nov 6, 2016
@ultraq
Document fix for #137
c81f70b
@ultraq ultraq closed this as completed Nov 6, 2016
@ultraq ultraq self-assigned this Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ultraq ultraq

Labels
enhancement
Projects
None yet
Milestone
Thymeleaf Layout Dialect 2.1
Development

No branches or pull requests
1 participant
@ultraq