Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify against JDK9 and Spring5 #161

Closed
ultraq opened this issue Sep 29, 2017 · 2 comments
Closed

Verify against JDK9 and Spring5 #161

ultraq opened this issue Sep 29, 2017 · 2 comments
Assignees
Labels

Comments

@ultraq
Copy link
Owner

ultraq commented Sep 29, 2017

Both Java 9 and Spring 5 came out recently, so it might be good to verify that everything here still works, plus to see if there's anything in the new versions that I can work towards in to keep things up-to-date.

@ultraq ultraq self-assigned this Sep 29, 2017
@ultraq ultraq changed the title Test against JDK9 and Spring5 Verify against JDK9 and Spring5 Sep 29, 2017
@ultraq
Copy link
Owner Author

ultraq commented Dec 25, 2017

After adding Java 9 to the CI build, it started failing because of the older version of Groovy. Had to up that to 2.4.13 (I think people reported that at least 2.4.12 was needed?) to get compilation and tests working again. So that's Java 9 sorted. Need to still try a Spring 5 (or Spring Boot 2?) project to make sure there are no surprises there either.

@ultraq ultraq added this to the Layout Dialect 2.3 milestone Feb 11, 2018
@ultraq
Copy link
Owner Author

ultraq commented Feb 11, 2018

Cool, works using Spring Boot 2.0 RC1 and Java 9 👍

@ultraq ultraq closed this as completed Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant