Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #57 #60

Merged
merged 1 commit into from
Nov 17, 2014
Merged

Fix for #57 #60

merged 1 commit into from
Nov 17, 2014

Conversation

oniekrenz
Copy link
Contributor

As I mentioned in #57 I found a solution and decided to fork and send this pull request.

Sorry for having the trailing whitespace removed in the comments as well. That was done automatically by the IntelliJ code formatter.

@ultraq
Copy link
Owner

ultraq commented Nov 14, 2014

Thanks for the pull request, I'll take a look at it this weekend.

Sorry for having the trailing whitespace removed in the comments as well. That was done automatically by the IntelliJ code formatter.

You can turn that off in the settings - I do like the whitespace in comments, but not in code. I don't think IntelliJ distinguishes between those yet, so I just leave them alone in my IntelliJ. Anyway, whitespace on just those comment sections isn't a biggie.

@ultraq
Copy link
Owner

ultraq commented Nov 15, 2014

Hey @oniekrenz, thanks again for the PR - I'm going to merge it.

One thing I ask of contributors is if they'd like to give me some details about themselves to add to the contributors section of the pom.xml file. If you'd like to be included, you can provide as much or as little information as you'd like, so long as it follows the spec for that section. http://maven.apache.org/pom.html#Contributors

Here's an example from a previous contributor (build.gradle#L40-L46) and how it appears in the final build product (thymeleaf-layout-dialect#1.2.7|pom.xml).

@oniekrenz
Copy link
Contributor Author

Ok, here is mine:
project.contributors = [
[
name: 'Oliver Niekrenz',
email: 'oliver@niekrenz.de
roles: ['developer'],
]
]

@ultraq
Copy link
Owner

ultraq commented Nov 17, 2014

👍

ultraq added a commit that referenced this pull request Nov 17, 2014
@ultraq ultraq merged commit 62b660a into ultraq:master Nov 17, 2014
@ultraq
Copy link
Owner

ultraq commented Nov 19, 2014

I've created a 1.2.8-SNAPSHOT version of the layout dialect which includes your changes.

@oniekrenz oniekrenz deleted the issue-57 branch July 14, 2015 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants