Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion failure when encoding only a few frames with --gop=8 #161

Closed
aryla opened this issue Mar 3, 2017 · 0 comments
Closed

Assertion failure when encoding only a few frames with --gop=8 #161

aryla opened this issue Mar 3, 2017 · 0 comments
Milestone
v1.2

Comments

@aryla
Copy link
Contributor

aryla commented Mar 3, 2017 

$ kvazaar -i test_seqs/hevc-F/BasketballDrillText_832x480_50_500.yuv -n2 --gop=8 -o /dev/null
Compiled: INTEL, flags: MMX SSE SSE2
Detected: INTEL, flags: MMX SSE SSE2 SSE3 SSSE3 SSE41 SSE42 AVX
Available: avx(11) sse2(2) sse41(1) 
In use: avx(11) 
--owf=auto value set to 1.
Input: test_seqs/hevc-F/BasketballDrillText_832x480_50_500.yuv, output: /dev/null
  Video size: 832x480 (input=832x480)
POC    0 QP 22 (I-frame)     492064 bits PSNR: 42.0295 43.9501 44.6937
pthread_mutex_lock(&depends_on->lock) failed!
kvazaar: threadqueue.c:605: kvz_threadqueue_job_dep_add: Assertion `0' failed.

Valgrind shows that some thread queue jobs are used after they have been freed: valgrind-log.txt
@aryla aryla added this to the v1.2 milestone Mar 3, 2017
aryla added a commit to aryla/kvazaar that referenced this issue Apr 12, 2017
@aryla
Add reference counting to threadequeue_job_t
83f0ce7 
Both the thread queue and the encoder states hold pointers to the thread
queue jobs. It is possible that a job is removed from the thread queue
and freed while the encoder state is still using it. This commit adds
reference counting to threadqueue_job_t in order to fix the problem.

Fixes ultravideo#161.
@aryla aryla closed this as completed in 2991962 Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
1 participant
@aryla