Handle both redis response codes on PTTL #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhoff
changed the title
|
Yep that make sense, thank you for your contribution 👍 |
|
Thanks @novln! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've periodically come across
cannot configure timeout on keyerrors being returned from this block of code, and I think I've narrowed it down to a race-condition in key presence when using.Getfrom multiple goroutines concurrently. It seems that in the odd case that that the ttl is set to-2(key doesn't exist) trying toexpirethat key returns!okwhich I think could be avoided by checking ifttl==-1instead ofttl<0. This would help ensure thatexpiredoesn't get called on a non-existant key. So far this has been working in my implementation but I'd like to know your thoughts @novln.Thanks for taking the time to read this!
https://redis.io/commands/pttl