Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reaction count when there are duplicate reaction events from a user #239

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Kladki
Copy link
Contributor

@Kladki Kladki commented Mar 29, 2024

Closes #228

@Kladki Kladki marked this pull request as draft March 30, 2024 10:18
@Kladki Kladki marked this pull request as ready for review March 30, 2024 10:22
@ulyssa ulyssa changed the title fix: only display a single reaction per user/key pair Fix reaction count when there are duplicate reaction events from a user Apr 2, 2024
@Kladki Kladki force-pushed the single-reaction-per-user-key branch from ad69306 to 2506da4 Compare April 2, 2024 15:14
@ulyssa
Copy link
Owner

ulyssa commented Apr 2, 2024

Thank you for tracking #228 down and fixing it! 🎉 I hadn't realized that homeservers allow this, so handling this and #240 client side is definitely the right approach.

@ulyssa ulyssa enabled auto-merge (squash) April 2, 2024 15:20
@ulyssa ulyssa merged commit 0f17bbf into ulyssa:main Apr 2, 2024
3 checks passed
@Kladki Kladki deleted the single-reaction-per-user-key branch April 2, 2024 20:08
@ulyssa ulyssa mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple equal reactions from user are displayed multiple times
2 participants