Fix newer Clippy warnings for 1.80 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: field `1` is never read --> src/message/html.rs:263:30 Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
|
Thank you for cleaning this up!
Each new edition of Rust/Clippy stablizes or adds new lints. Since I don't want to force folks to have to be responsible for fixing new lints every time there's a new release of Rust, the CI workflow runs Clippy using the MSRV for iamb (currently 1.70) which doesn't warn on the checks fixed here. |
ulyssa
changed the title
ulyssa
force-pushed
the
fix/clippy-issues
branch
from
84ac84f
to
7df7419
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to take this client to my own use but as long as it breaks "broken glass" invariant I really cannot do that ;-) [1]
Is there something broken in the CI, I see that there are some clippy bits but cannot comprehend why those checks are not working?
[1] "Fight software rot" chapter in "Pragmatic Programmer"