Include room name in desktop notifications #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the room name to desktop notifications, and sends the
iambicon name so that folks with an icon installed under/usr/share/icons/will see it in the notification.I've also created a new
desktopdefault feature with the goal of making it possible to compile with or without pulling inarboardandnotify-rustand all of the x11/wayland/dbus dependencies, which should make it easier to compile smalleriambbinaries that run on a remote machine and are used over SSH. This effort seems to be currently thwarted bymodalkit-ratatui's dependency onmodalkitenabling thedefault-featuresset and pulling inarboard, so it will be imperfect until I do something about that.