Change default for last_column in EditContext
#146
Merged
+108
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssa
force-pushed
the
last-column-default
branch
from
c42e4d8
to
e378161
Compare
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into ulyssa/iamb#297, I think I've convinced myself that the default that
EditContext/EditContextBuilderuses forlast_columnis wrong and a potential footgun that results in accidentally misusingInsertTextActionand others outside of a keybinding context. It should default totrueso that buildingActionvalues from scratch don't unexpectedly clamp the cursor, but require explicitly requesting that behaviour via the builder interface.