Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect dependency version requirement #271

Merged
merged 2 commits into from
Feb 20, 2023
Merged

fix incorrect dependency version requirement #271

merged 2 commits into from
Feb 20, 2023

Conversation

ppoffice
Copy link
Contributor

@AdrianKs
Copy link
Collaborator

Thank you for the PR.
We would like to be able to always use the newest version of the packages if possible. Therefore, it would be preferable to remove the wildcard instead of the >=.
numpy>=1.19.0

@ppoffice
Copy link
Contributor Author

ppoffice commented Feb 16, 2023

@AdrianKs Here you go.

BTW, I think using compatible release versions instead of the latest version will ensure dependency compatibility. For instance, you can't prevent pip from installing numba 1.0.0 when it's available if you set numba>=0.50.0 as a dependency. And usually a major upgrade like 0.x.x to 1.0.0 introduces breaking changes. On the contrary, setting numba~=0.50.0 will make sure you never upgrade to numba 1.0.0.

@ppoffice
Copy link
Contributor Author

Would you kindly merge this PR if there is no more issue with it? Thanks.

@AdrianKs
Copy link
Collaborator

Yes, sure. Sorry for the late reply.
Thank you for the pointer to using ~=.
We will merge as it is for now with >= and discuss later on how we want to treat major releases of packages.

@AdrianKs AdrianKs merged commit f4fa52d into uma-pi1:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants