Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with multiple comments in template #25

Closed
jwellner opened this issue Jan 8, 2018 · 2 comments
Closed

Issue with multiple comments in template #25

jwellner opened this issue Jan 8, 2018 · 2 comments
Labels

Comments

@jwellner
Copy link
Contributor

jwellner commented Jan 8, 2018

    it('test comments', function () {
      var t = new jSmart('Testing {* testing *}, does it {* multiple comments *}work?')
      expect(t.fetch()).toBe('Testing , does it work?')
    })

Result:

Error: Unclosed /{\*/* in src/parser/parser.js (line 667)
removeComments@src/parser/parser.js:667:54
getTree@src/parser/parser.js:54:37
getParsed@src/parser/parser.js:83:30
parse@src/core.js:199:46
jSmart@src/core.js:82:15
test/basic-spec.js:43:25
@umakantp
Copy link
Owner

Thank you @jwellner for reporting and pushing the patch with it. I'm taking merge.

After fixing other reported bugs, I will release the new minor version.

umakantp added a commit that referenced this issue Jan 10, 2018
Fixes issue #25 where open/close comment tags where not matched correctly
@umakantp
Copy link
Owner

Approved the merge request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants