UMD (Universal Module Definition) #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avcajaraville
added a commit
to Avcajaraville/jsmart
that referenced
this pull request
May 10, 2016
- Add UMD, CommonJS & web/browser support. Based on [this pull request](umakantp#14). - Remove **String.prototype.fetch** function (since this is a very bad practice), and instead, modifying the export of the module. Now it exports the constructor and the fetch function. - The module now exports the following object: `{ jSmart: jSmart, fetch: fetch }`. This is, `jSmart` constructor and `fecth` function
Avcajaraville
added a commit
to Avcajaraville/jsmart
that referenced
this pull request
May 10, 2016
- Add UMD, CommonJS & web/browser support. Based on [this pull request](umakantp#14). - Remove **String.prototype.fetch** function (since this is a very bad practice), and instead, modifying the export of the module. Now it exports the constructor and the fetch function. - The module now exports the following object: `{ jSmart: jSmart, fetch: fetch }`. This is, `jSmart` constructor and `fecth` function
Avcajaraville
added a commit
to Avcajaraville/jsmart
that referenced
this pull request
May 10, 2016
- Add UMD, CommonJS & web/browser support. Based on [this pull request](umakantp#14). - Remove **String.prototype.fetch** function (since this is a very bad practice), and instead, modifying the export of the module. Now it exports the constructor and the fetch function. - The module now exports the following object: `{ jSmart: jSmart, fetch: fetch }`. This is, `jSmart` constructor and `fecth` function
|
This feature already exists. See commits done after:- Aug 11, 2015 Please use the latest version. |
|
Nice! Thanks for adding AMD and CommonJS support. Yet there is something not really good about this code in Browser environment: (function(){
// ...
jSmart = function(tpl) { /*...*/ };
// ...
}());For someone with enough expertise in JS this looks like assigning a function to a global variable, which still is not quite obvious, as you have to scan the entire IIFE function to make sure there is nothing like On the other hand, it doesn't work well for minification and runtime performance, as accessing a global variable is much slower than accessing a local variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added AMD and CommonJs support to jSmart.
This should close issue #10