the events count in a session detail page is not right

[pinkli]

Describe the Bug

the count is the same as views, see code

umami/src/queries/analytics/sessions/getWebsiteSession.ts

Line 50 in 1b6429f

sum(case when website_event.event_type = 1 then 1 else 0 end) as events

should change to case when website_event.event_type = 1 then 0 else 1 end

Database

PostgreSQL

Relevant log output

No response

Which Umami version are you using? (if relevant)

master branch

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

[franciscao633]

Feel free to put in a PR, but it should be the below. We currently only have two event types, but targeting event_type = 2, should protect us if we add more. Thanks for catching this.

sum(case when website_event.event_type = 2 then 1 else 0 end) as events

[mikecao]

Fixed in v2.14.0.