Be more liberal in what chars a variable can contain

May break some undocumented cases… cf #139 #676
umap-project · Jul 20, 2023 · 95e1745 · 95e1745
1 parent a065477
commit 95e1745
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/umap/static/umap/js/umap.core.js b/umap/static/umap/js/umap.core.js
@@ -174,7 +174,7 @@ L.Util.greedyTemplate = (str, data, ignore) => {
   }
 
   return str.replace(
-    /\{ *([\w_\:\.\|@]+)(?:\|("[^"]*"))? *\}/g,
+    /\{ *([^\{\}/\-]+)(?:\|("[^"]*"))? *\}/g,
     (str, key, staticFallback) => {
       const vars = key.split('|')
       let value

diff --git a/umap/static/umap/test/Util.js b/umap/static/umap/test/Util.js
@@ -245,6 +245,25 @@ describe('L.Util', function () {
       )
     })
 
+    it('should accept space', function () {
+      assert.equal(
+        L.Util.greedyTemplate('A phrase with a {var iable}.', {
+          'var iable': 'value',
+        }),
+        'A phrase with a value.'
+      )
+    })
+
+    it('should accept non ascii chars', function () {
+      assert.equal(
+        L.Util.greedyTemplate('A phrase with a {Accessibilité} and {переменная}.', {
+          'Accessibilité': 'value',
+          'переменная': 'another',
+        }),
+        'A phrase with a value and another.'
+      )
+    })
+
     it('should replace even with ignore if key is found', function () {
       assert.equal(
         L.Util.greedyTemplate(