Some users don’t have their maps in "my maps" page

[ldidry]

Describe the bug
In "my maps" page, some users (not all of them) don’t see their maps. It can be no maps, or just some of them

To Reproduce
Steps to reproduce the behavior:

1. Go to "my maps" page
2. no maps, or not all of them

Expected behavior
Have all of your maps

Additional context
It’s a regression due to 9af5375. I reverted the commit and it’s now working as before.

Problem: I didn’t experience the bug myself, so I can’t dig it deep. I just now that reverting the commit fixes it.

[yohanboniface]

@ldidry ah, damn, that may be a side effect of #1196 : "My maps" should logically now point to this dashboard page, but I realize that for framacarte, given we quite changed the HTML, this is certainly not the case, and it may be not easy to use it. What do you think ?

This is one more occasion for me to think "how can I properly communicate about the changes to the maintainers of uMap servers". If you have suggestion, I'm happy to ear them :)

[yohanboniface]

See https://github.com/umap-project/umap/blob/master/umap/templates/umap/navigation.html#L12

[yohanboniface]

Here is a diff:

diff --git a/templates/umap/navigation.html b/templates/umap/navigation.html
index 1be9c0c..fdd8fb3 100644
--- a/templates/umap/navigation.html
+++ b/templates/umap/navigation.html
@@ -4,7 +4,7 @@
     <div class="container">
         <ul class="nav navbar-nav navbar-right">
           {% if user.is_authenticated %}
-          <li><a href="{% url 'user_maps' user.username %}">{% trans "My maps" %} ({{ user }})</a></li>
+          <li><a href="{% url 'user_dashboard' %}">{% trans "My maps" %} ({{ user }})</a></li>
           {% else %}
           <li><a href="{% url 'login' %}" class="login">{% trans "Log in" %} / {% trans "Sign in" %}</a></li>
           {% endif %}

Which then points to the dashboard, which looks like this:

@ldidry should I make a PR ?

[ldidry]

should I make a PR ?

No, thank you, I fixed the template.

"how can I properly communicate about the changes to the maintainers of uMap servers". If you have suggestion, I'm happy to ear them :)

Maybe a "⚠️ Be careful with this changes!" section in releases or something like that? I follow the RSS feed to know when there’s a new release, so I would personally see such communication.

[ldidry]

Anyway, thank you for the fix (I’m waiting for an impact user to say if it’s all right).

[almet]

Hey @ldidry 🤗

On some other projects, we were adding some more information in the changelogs, to make this more easy to spot.

We could then have different sections in the changelog, like:

• Breaking Changes
• New features
• Documentation
• Bug Fixes
• Internal changes

Would that make it easier to get the information?

[ldidry]

Add a link to the changelog in the releases and it should be enough 🙂

[yohanboniface]

Not sure where you expect this link, @ldidry ?

We maintain this and this already, but it may be easy to add the info somewhere else :)

[ldidry]

I thought that the changelog file was bigger than the release text and that you wanted to put the sections in only the file.

The different sections in changelog (file and release) will be good 👍

[yohanboniface]

Should we close here ? :)

[ldidry]

Sure, sorry.